Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make data safer by default.in case user delete pvc by accident , and limit RBAC hwameistor-role permissions #289

Merged
merged 2 commits into from
Jul 26, 2024
Merged

make data safer by default.in case user delete pvc by accident , and limit RBAC hwameistor-role permissions #289

merged 2 commits into from
Jul 26, 2024

Conversation

peng9808
Copy link
Collaborator

@peng9808 peng9808 commented Jul 15, 2024 •
edited
Loading

@peng9808
Copy link
Collaborator Author

@SSmallMonster Added helm set storageClassReclaimPolicy=Retain or Delete...

@SSmallMonster SSmallMonster mentioned this pull request Jul 15, 2024
Merged
@SSmallMonster SSmallMonster self-requested a review July 15, 2024 12:35
@peng9808 peng9808 changed the title make data safer by default.in case user delete pvc by accident , and … make data safer by default.in case user delete pvc by accident , and limit RBAC hwameistor-role permissions Jul 26, 2024
SSmallMonster
SSmallMonster approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@SSmallMonster SSmallMonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

helm/operator/values.yaml Outdated Show resolved Hide resolved
helm/operator/values.yaml Show resolved Hide resolved
@peng9808 peng9808 merged commit 2ad3d82 into hwameistor:main Jul 26, 2024
2 checks passed
@peng9808 peng9808 mentioned this pull request Jul 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSmallMonster SSmallMonster SSmallMonster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peng9808 @SSmallMonster